Ticket #1 (closed enhancement: fixed)

Opened 3 years ago

Last modified 3 years ago

Split out amf.py to amf0.py and amf3.py

Reported by: nick Owned by: nick
Priority: blocker Milestone: 0.1 Beta
Component: Encoder Version: 0.1a
Keywords: Cc:
Fixed in revision: Branch:
Author:

Description (last modified by nick) (diff)

amf.py contains implementations for both versions of the protocol. AMF3 is a bit more involved than AMF0 and it is wasteful to import all that unnecessary code if AMF0 is just the encoding of choice.

amf0 would 'know' of amf3 and import it at runtime if the relevant type is processed (0x11).

Change History

comment:1 Changed 3 years ago by nick

  • Description modified (diff)

comment:2 Changed 3 years ago by nick

  • Keywords review added
  • Status changed from new to accepted

Ready for review in source:/branches/split-versions-1

comment:3 Changed 3 years ago by arnar

Ok with me.

comment:4 Changed 3 years ago by nick

  • Status changed from accepted to closed
  • Resolution set to fixed

(In [22]) Merge split-policies-1

Author: nick Reviewer: arnar Fixes #1

comment:5 Changed 3 years ago by nick

  • Keywords review removed

comment:6 Changed 3 years ago by thijs

  • Version set to 0.1a
Note: See TracTickets for help on using tickets.