Ticket #306 (closed enhancement: fixed)

Opened 22 months ago

Last modified 19 months ago

User-Agent missing in AMF client

Reported by: thijs Owned by: thijs
Priority: minor Milestone: 0.4
Component: Client Version: 0.3.1
Keywords: user-agent Cc:
Fixed in revision: Branch:
Author:

Description (last modified by thijs) (diff)

When the AMF client POSTs on the server it leaves this in the log files: 

1.2.3.4 - - [06/Jun/2008:22:28:41 +0200] "POST /gateway/recordset HTTP/1.1" 200 325 "-" "-"

Looks like the User-Agent is missing, ie: 

1.2.3.4 - - [06/Jun/2008:15:15:35 -0500] "POST /gateway/bytearray/ HTTP/1.1" 200 135 "http://svn.pyamf.org/www/trunk/demo/bytearray.swf" "Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.14) Gecko/20080404 Firefox/2.0.0.14"

Attachments

user-agent-306.patch Download (6.1 KB) - added by thijs 21 months ago.
Patch against r1464
test-306.py Download (0.6 KB) - added by thijs 21 months ago.
Test client for user-agent

Change History

  Changed 22 months ago by thijs

  • keywords user-agent, referrer added
  • description modified (diff)

follow-ups: ↓ 3 ↓ 6   Changed 22 months ago by nick

  • priority changed from major to trivial

What would the referrer be in this case?

Leaving it blank, but giving the option to modify it would be be the best solution I think.

in reply to: ↑ 2   Changed 22 months ago by thijs

Replying to nick:

What would the referrer be in this case?

Probably the filename (gateway.py)?

Leaving it blank, but giving the option to modify it would be be the best solution I think.

That sounds good for the referrer. It should also be possible to modify the user agent but always have a default like {{{"Python/2.5.2 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.14) PyAMF/0.3.1"]]]?

  Changed 21 months ago by thijs

  • owner changed from nick to thijs
  • priority changed from trivial to minor
  • status changed from new to accepted
  • description modified (diff)
  • milestone changed from 0.4 to 0.3.2

  Changed 21 months ago by thijs

  • keywords review added; referrer removed
  • owner changed from thijs to nick
  • status changed from accepted to assigned

Attached a patch that results in the following string in the Apache logs: 

1.2.3.4 - - [20/Jun/2008:16:57:37 +0200] "POST / HTTP/1.1" 200 2517 "-" "PyAMF/0.4.0"

Also updated the tests that pass. Assigning to Nick for review.

in reply to: ↑ 2   Changed 21 months ago by thijs

  • summary changed from User-Agent missing for AMF client to User-Agent missing in AMF client

Replying to nick:

What would the referrer be in this case? Leaving it blank, but giving the option to modify it would be be the best solution I think.

I opened #316 for the referrer.

  Changed 21 months ago by thijs

Created a branch that includes an update of the patch and more.

Changed 21 months ago by thijs

Patch against r1464

Changed 21 months ago by thijs

Test client for user-agent

  Changed 21 months ago by nick

  • keywords user-agent added; user-agent, review removed
  • owner changed from nick to thijs

Once the replacement for 'application/x-amf' is removed this can be merged.

  Changed 21 months ago by thijs

  • status changed from assigned to closed
  • resolution set to fixed

Applied in r1473.

  Changed 19 months ago by thijs

  • component changed from Remoting to Client
Note: See TracTickets for help on using tickets.