RemotingService raises TypeError when deserializing an ArrayCollection

[mrflay]

I have a pyamf 0.4.1 client that communicates with a BlazeDS 3.0.0.544 service running in a JBoss 4.2 application server.

The following error is raised on the client when an ArrayCollection is being deserialized.

Traceback (most recent call last):
  File "test.py", line 19, in <module>
    print service.list("3F3A66CA-B1BE-73D6-276D-D7CA9453BA90")
  File "build/bdist.linux-i686/egg/pyamf/remoting/client/__init__.py", line 52, in __call__
  File "build/bdist.linux-i686/egg/pyamf/remoting/client/__init__.py", line 101, in _call
  File "build/bdist.linux-i686/egg/pyamf/remoting/client/__init__.py", line 409, in execute_single
  File "build/bdist.linux-i686/egg/pyamf/remoting/client/__init__.py", line 479, in _getResponse
  File "build/bdist.linux-i686/egg/pyamf/remoting/__init__.py", line 615, in decode
  File "build/bdist.linux-i686/egg/pyamf/remoting/__init__.py", line 454, in _read_body
  File "build/bdist.linux-i686/egg/pyamf/__init__.py", line 677, in readElement
  File "build/bdist.linux-i686/egg/pyamf/amf0.py", line 318, in readTypedObject
  File "build/bdist.linux-i686/egg/pyamf/amf0.py", line 365, in _readObject
  File "build/bdist.linux-i686/egg/pyamf/__init__.py", line 554, in applyAttributes
  File "build/bdist.linux-i686/egg/pyamf/util/__init__.py", line 767, in set_attrs
TypeError: list indices must be integers

Cause:

The set_attrs method cannot initialize the ArrayCollection since it expects the associated attrs data to be an array, but it is actually an object {'source':[{'foo':'bar'},...]}.

Adding the following code

    if isinstance(obj, pyamf.flex.ArrayCollection):
        obj.extend(attrs['source'])
        return

to the beginning of the set_attrs method allows the ArrayCollection to be deserialized on the client.

[mrflay]

patch

[nick]

PyAMF should support the  source property.

[thijs]

mrflay, could you take a stab at unit tests for this change as well? Nick already created a branch at pyamf/branches/arraycollection-source-488 that you can work against. As noted in the previous comment, we need to support an additional source property for ArrayCollection.

[mrflay]

Sure, I'll take a look at it.

[nick]

I have applied a change for this in r2276 (including tests). Can you check this against BlazeDS to ensure that this is now working?

Thanks!

[thijs]

The pyflakes step is failing:  http://buildbot.pyamf.org/builders/x86-macosx-py25/builds/100/steps/pyflakes

After that it's ready to merge.