Ticket #490 (closed defect: fixed)

Opened 12 months ago

Last modified 12 months ago

Missing microseconds in datetime objects

Reported by: thijs Owned by: nick
Priority: major Milestone: 0.4.2
Component: Utility Version: 0.4.1
Keywords: Cc: derek.payton@…
Fixed in revision: Branch: pyamf/branches/datetime-microseconds-490
Author: dmpayton

Description

When testing with the attached client Download it prints: 

in:  2009-03-06 18:46:36.913483
out: 2009-03-06 18:46:36

When applying the attached patch Download it prints the correct datetime: 

in: 2009-03-07 16:26:48.664044
out: 2009-03-07 16:26:48.664044

Reported on the  mailinglist by Derek Payton.

Attachments

test-client.py Download (244 bytes) - added by thijs 12 months ago.
datetime.patch Download (0.5 KB) - added by thijs 12 months ago.
test_util.diff Download (0.5 KB) - added by dmpayton 12 months ago.
test_results.txt Download (352 bytes) - added by dmpayton 12 months ago.

Change History

Changed 12 months ago by thijs

Changed 12 months ago by thijs

Changed 12 months ago by nick

  • owner changed from nick to derekpayton
  • status changed from new to assigned

Looks good although to accept the patch, we're going to need unit tests.

Are you willing to supply them?

Changed 12 months ago by dmpayton

Changed 12 months ago by dmpayton

Changed 12 months ago by dmpayton

  • cc derek.payton@… added
  • owner changed from derekpayton to dmpayton
  • author changed from derekpayton to dmpayton

Test added, please let me know if you need more.

Changed 12 months ago by thijs

  • keywords review added
  • owner changed from dmpayton to nick

Assigning to Nick for review.

Changed 12 months ago by nick

  • keywords review removed
  • status changed from assigned to accepted
  • branch set to pyamf/branches/datetime-microseconds-490

Looks good - I added some tests to ensure support in AMF0/AMF3.

Thanks for the patch!

Changed 12 months ago by nick

  • status changed from accepted to closed
  • resolution set to fixed

Merged in r2244.

Note: See TracTickets for help on using tickets.