[Patch] Django test client

[madssj]

I've created a test client that can be used with django's test framework.

[thijs]

In order to integrate this into PyAMF we need some unit tests for this new code. You want to take a stab at that Mads?

[madssj]

I may, what needs to be done, and where does it need to be done?

[thijs]

I guess Nick would have a definite answer to that question but it seems to me that it would go in pyamf/trunk/pyamf/remoting/client/django/__init__.py or pyamf/trunk/pyamf/remoting/client/django.py. We're also planning to add a Twisted AMF client (#434) that would probably go in a similar place (pyamf/trunk/pyamf/remoting/client/twisted/__init__.py or pyamf/trunk/pyamf/remoting/client/twisted.py). What do you think?

[madssj]

Because this is strictly a client that can be used for testing purposes, I think it would need to change name to TestClient or something like that, should it be located in pyamf.remoting.client.django.

Other than that, you didn't really answer anything about what kinds of unit tests this client would need :)

[nick]

p.r.c.django.TestClient is a good name.

The unit tests that would be required would need to cover expected use-cases (something along the lines of the example in the docstring). i.e. pass in a django Client instance and you can still use the remoting client.

I would suggest setting up a mini django app (see the  adapter test suite for a very hacky way we have set something up to run in our test suite) which would set a DjangoGateway at /gateway/ with a known service and check the response to calling it. More tests would need to be added to make sure the correct error response is being generated also.

Hope that gives you an indication of the kind of things we are looking for.

[nick]

Since tests aren't going to be included and the code for the client is attached here and in other blogs etc. I am closing this out. If unittests are developed in the future, this could be re-examined.